bruno added a comment.


> See also PR22165.

Nice, seems related to this indeed. Are you aware of any development along 
those lines in clang-tidy? We would like this to be part of clang and be used 
as part of the normal compiler workflow, it can surely be as well part of any 
clang-tidy related include guidelines in the future.

>> The warning is off by default.
> 
> We typically do not add off-by-default warnings because experience has shown 
> the rarely get enabled in practice. Can you explain a bit more about why this 
> one is off by default?

Right. I believe this is going to be used in practice, the reason I'm adding it 
involves some user demand for such warning. Such quoted include use in 
frameworks happen often and we would like a smooth transition to happen here 
(e.g. do not initially affect -Werror users). If it proves worth it, we can 
migrate to on by default in the future. It wouldn't be a problem if we have it 
on by default on open source and disable by default downstream, but I rather be 
consistent.


Repository:
  rC Clang

https://reviews.llvm.org/D47157



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to