rjmccall added a comment.
Thanks, that looks a lot better. One minor piece of feedback, but otherwise
LGTM.
================
Comment at: lib/Sema/SemaExpr.cpp:4402
+ Qualifiers MemberQuals =
+ Context.getCanonicalType(ResultType).getQualifiers();
+ Qualifiers Combined = BaseQuals + MemberQuals;
----------------
You shouldn't have to get the canonical type here.
================
Comment at: test/Sema/assign.c:17
+ b[4] = 1; // expected-error {{cannot assign to variable 'b' with
const-qualified type 'const arr' (aka 'int const[10]')}}
+ b2[4] = 1; // expected-error {{cannot assign to variable 'b2' with
const-qualified type 'const int [10]'}}
}
----------------
These are nice improvements, thanks. There's still room for getting ever
better, but this is already nice progress.
https://reviews.llvm.org/D42530
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
