jolesiak added inline comments.

================
Comment at: lib/Format/Format.cpp:765
     GoogleStyle.ColumnLimit = 100;
+    GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
   }
----------------
If I understand correctly this is meant to be ObjC-specific flag. I feel like 
this should be put in general config (next to 
GoogleStyle.ObjcSpaceAfterProperty and GoogleStyle.ObjCSpaceBeforeProtocolList; 
~50 lines above).
To me putting it inside 'if' check means different value is used for ObjC than 
for other languages (what isn't the case here, as this flag shouldn't be used 
in formatting other languages code). 


Repository:
  rC Clang

https://reviews.llvm.org/D42708



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to