JonasToth marked 5 inline comments as done. JonasToth added inline comments.
================ Comment at: docs/ReleaseNotes.rst:63 + + The usage of ``goto`` has been discouraged for a long time and is diagnosed + with this check. ---------------- Eugene.Zelenko wrote: > I think will be good idea to reformulate this statement and its copy in > documentation. //diagnosed with this check// is tautological for any check. Reformulated, is it ok now? ================ Comment at: docs/clang-tidy/checks/cppcoreguidelines-avoid-goto.rst:6-7 + +The usage of ``goto`` has been discouraged for a long time and is diagnosed +with this check. + ---------------- aaron.ballman wrote: > This doesn't really help the user understand what's bad about goto or why it > should be diagnosed. You should expound a bit here. Is it better now? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
