JonasToth marked 3 inline comments as done.
JonasToth added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:20
+
+AST_MATCHER(GotoStmt, isForwardJumping) {
+
----------------
lebedev.ri wrote:
> JonasToth wrote:
> > lebedev.ri wrote:
> > > It would be nice to have it in standard ASTMatchers, i believe it will be
> > > useful for `else-after-return` check.
> > > Though the ASTMatchers are stuck due to the doc-dumping script being
> > > 'broken' (see D41455)
> > Yes. The GNU extension goto does not have ASTMatcher yet, so i will pack
> > these together in a review. What do you think how long the ASTMatcher issue
> > will be there? Maybe it could be done after that check lands?
> > Maybe it could be done after that check lands?
>
> Yes, absolutely. I did not meant that as a blocker here.
On my todo list.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
