jbcoe requested changes to this revision.
jbcoe added inline comments.
This revision now requires changes to proceed.
================
Comment at: unittests/libclang/LibclangTest.cpp:596
+TEST_F(LibclangPrintingPolicyTest, GetProperty) {
+ EXPECT_EQ(2U, clang_PrintingPolicy_getProperty(Policy,
CXPrintingPolicy_Indentation));
+}
----------------
nik wrote:
> jbcoe wrote:
> > It would be useful, albeit tedious, to add get/set test pairs for each
> > property.
> I think we have the basic functionality of the getter and setter covered.
> Testing each getter/setter for each property would mostly help to verify the
> mapping in the getters/setters - initially I've ruled out that possibility
> with the macros (once the macro is correct - but that's much easier to
> check). I would prefer to go back to the macro version than adding a test
> here that goes over all properties.
I think the macro in implementation harms readability and the tests are pretty
simple to add (maybe even using a macro).
The current setup of a switch and no low-level tests leaves things open to
breakage in future.
Repository:
rC Clang
https://reviews.llvm.org/D39903
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
