szepet accepted this revision.
szepet added a comment.
In https://reviews.llvm.org/D41444#961110, @a.sidorin wrote:
> Test both with and without '-fdelayed-template-parsing' in C++ mode.
This solution LGTM as well.
Just a small nit added inline.
================
Comment at: unittests/AST/ASTImporterTest.cpp:68
+ const std::string &FromCode, const std::string &ToCode,
+ MatchVerifier<NodeType> &Verifier, const MatcherType &AMatcher) {
const char *const InputFileName = "input.cc";
----------------
Nit: Maybe the order of the parameters could stay similar as the original:
FromCode, FromArgs, ToCode, ToArgs, Verifier, AMatcher. (Or just Codes before
Args)
It seems more intuitive to me.
Repository:
rC Clang
https://reviews.llvm.org/D41444
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
