[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

[Aleksei Sidorin via Phabricator via cfe-commits]

a.sidorin created this revision.
a.sidorin added reviewers: NoQ, xazax.hun, szepet.
Herald added subscribers: cfe-commits, rnkovacs.

While running ASTImporterTests, we often forget about Windows MSVC buildbots 
which enable '-fdelayed-template-parsing' by default. It takes reviewing time 
to find such issues as well as unexpected buildbot failures. To solve this 
issue, I suggest making '-fdelayed-template-parsing' mandatory so this problem 
can be caught during development.


Repository:
  rC Clang

https://reviews.llvm.org/D41444

Files:
  unittests/AST/ASTImporterTest.cpp


Index: unittests/AST/ASTImporterTest.cpp
===================================================================
--- unittests/AST/ASTImporterTest.cpp
+++ unittests/AST/ASTImporterTest.cpp
@@ -33,10 +33,10 @@
     Args.insert(Args.end(), { "-x", "c", "-std=c89" });
     break;
   case Lang_CXX:
-    Args.push_back("-std=c++98");
+    Args.insert(Args.end(), {"-std=c++98", "-fdelayed-template-parsing"});
     break;
   case Lang_CXX11:
-    Args.push_back("-std=c++11");
+    Args.insert(Args.end(), {"-std=c++11", "-fdelayed-template-parsing"});
     break;
   case Lang_OpenCL:
   case Lang_OBJCXX:



Index: unittests/AST/ASTImporterTest.cpp
===================================================================
--- unittests/AST/ASTImporterTest.cpp
+++ unittests/AST/ASTImporterTest.cpp
@@ -33,10 +33,10 @@
     Args.insert(Args.end(), { "-x", "c", "-std=c89" });
     break;
   case Lang_CXX:
-    Args.push_back("-std=c++98");
+    Args.insert(Args.end(), {"-std=c++98", "-fdelayed-template-parsing"});
     break;
   case Lang_CXX11:
-    Args.push_back("-std=c++11");
+    Args.insert(Args.end(), {"-std=c++11", "-fdelayed-template-parsing"});
     break;
   case Lang_OpenCL:
   case Lang_OBJCXX:

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits