faisalv added inline comments.

================
Comment at: lib/Parse/ParseTemplate.cpp:692
+  //   declaration.
+  auto ReportStorageClass = [&](SourceLocation Loc) {
+    if (ParamDecl.getIdentifier())
----------------
I tend to prefer explicit captures (unless you have a good reason?) - favoring 
a clearer description of intention - and acknowledgement of required context - 
over programming convenience ...  


https://reviews.llvm.org/D40705



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to