================
@@ -1100,6 +1100,334 @@ const ProgramPointTag *ExprEngine::cleanupNodeTag() {
   return &cleanupTag;
 }
 
+namespace {
+enum VisitKind {
+  PreVisitKind,
+  PostVisitKind,
+};
----------------
NagyDonat wrote:

```suggestion
enum class VisitKind {
  Pre,
  Post,
};
```
I think this would improve readability.

When I see `VisitKind::Pre`, I immediately see that this is an enum constant, 
but when I've seen `PreVisitKind` for a moment I was puzzled by "where is this 
local defined? or is this a data member?" before realizing that it is from an 
enum.

https://github.com/llvm/llvm-project/pull/218691
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to