https://github.com/NagyDonat approved this pull request.
The PR looks good to me. I reviewed the changes commit-by-commit, and I can confirm that the PR is indeed NFC assuming that the bulk switch manipulation commits (https://github.com/llvm/llvm-project/pull/218691/changes/c602cc03464b355be70ed54ce7ec497c30d30223 https://github.com/llvm/llvm-project/pull/218691/changes/492717d67933965a8587da50891a6797e8f64173 and https://github.com/llvm/llvm-project/pull/218691/changes/6432b27cfd67624a2a1b4076e27f7914cafa697c) do what their description claims (I did not verify them). In my inline comments I suggested some stylistic improvements – please handle those before merging. I'll also run a sanity check in our CI, please wait for its results as well. https://github.com/llvm/llvm-project/pull/218691 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
