JonasToth marked 4 inline comments as done.
JonasToth added inline comments.
================
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:98
+ // hold.
+ const std::size_t BitCount = [&T, &Context]() {
+ if (T->isIntegralType(Context))
----------------
JDevlieghere wrote:
> Unless you expect a whole bunch of logic to be added here, I'd un-const and
> initialize BitCount to zero, then just have if-clause reassign it and get rid
> of the lambda. This will save you a few lines of code and complexity.
I dont know if i missed some integral types, that need special care, so this
one was defensive.
But with the refactoring i made, I should change this, agreed.
https://reviews.llvm.org/D37808
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
