aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from a small nit, this LGTM, thanks!



================
Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:102-105
+  auto TextRange =
+      Lexer::getAsCharRange(SourceRange(NestedNamespaceBegin, 
LBracketLocation),
+                            Sources, getLangOpts());
+  auto NestedNamespaceName =
----------------
These should not use `auto` since the type is not explicitly spelled out in the 
initialization.


https://reviews.llvm.org/D38284



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D38284: ... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D38... Alexandru Octavian Buțiu via Phabricator via cfe-commits
    • [PATCH] D38... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D38... Alexandru Octavian Buțiu via Phabricator via cfe-commits
    • [PATCH] D38... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexandru Octavian Buțiu via Phabricator via cfe-commits

Reply via email to