anatol.pomozov added a comment.

> As I said, as long as BOTH windows versions have the same issue, I think _I_ 
> am OK with it.

The tests fail at windows the same way. The only difference - "attribute is not 
supported at 64bit" compiler warning is gone with my change.

> if we corrected the attribute spelling to be GCC instead of GNU and added 
> some documentation to the attribute

These are great suggestions! But I think it makes more sense to have a separate 
change for it as it orthogonal to what I am trying to do here. Having separate 
commits for independent changes is better as it makes things like bisecting and 
rollbacks easier.


https://reviews.llvm.org/D36272



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to