aaron.ballman added a comment. In https://reviews.llvm.org/D36272#851709, @erichkeane wrote:
> Aaron would likely know better than me... but could it be the spelling type > should be GCC instead of GNU? Yes, this should be spelled with `GCC` rather than `GNU`, as it's a documented GCC attribute and needs the C++11 spelling you get from that switch. That doesn't have to be a part of this patch, however, when it gets done, we should also add documentation to AttrDocs.td for the attribute. ================ Comment at: lib/CodeGen/TargetInfo.cpp:2293 + // Get the LLVM function. + llvm::Function *Fn = cast<llvm::Function>(GV); + ---------------- You can use `auto *` here instead of spelling out the type twice. ================ Comment at: lib/CodeGen/TargetInfo.cpp:2430 + // Get the LLVM function. + llvm::Function *Fn = cast<llvm::Function>(GV); + ---------------- You can use `auto *` here as well. https://reviews.llvm.org/D36272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
