================
@@ -281,13 +276,8 @@ class NodeBuilder {
}
/// Generates a node in the ExplodedGraph.
- /// TODO: This is a useless wrapper layer, rename `generateNodeImpl` to
- /// `generateNode`.
- ExplodedNode *generateNode(const ProgramPoint &PP,
- ProgramStateRef State,
- ExplodedNode *Pred) {
- return generateNodeImpl(PP, State, Pred);
- }
+ ExplodedNode *generateNode(const ProgramPoint &PP, ProgramStateRef State,
+ ExplodedNode *Pred, bool MarkAsSink = false);
----------------
NagyDonat wrote:
> If I can ask for something, it would be to try to distill replies and PR
> summaries, comments to what is strictly necessary.
Good point. I know that I tend to write too much, especially if I'm tired, but
I'll try to limit this.
There _are_ a few situations when even a very long reply can be strictly
necessary (because the code is so complex), but you're right that e.g. this
comment and many others are too verbose.
https://github.com/llvm/llvm-project/pull/182377
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
