================
@@ -281,13 +276,8 @@ class NodeBuilder {
   }
 
   /// Generates a node in the ExplodedGraph.
-  /// TODO: This is a useless wrapper layer, rename `generateNodeImpl` to
-  /// `generateNode`.
-  ExplodedNode *generateNode(const ProgramPoint &PP,
-                             ProgramStateRef State,
-                             ExplodedNode *Pred) {
-    return generateNodeImpl(PP, State, Pred);
-  }
+  ExplodedNode *generateNode(const ProgramPoint &PP, ProgramStateRef State,
+                             ExplodedNode *Pred, bool MarkAsSink = false);
----------------
steakhal wrote:

As you wish. If I can ask for something, it would be to try to distill replies 
and PR summaries, comments to what is strictly necessary. IU usually only have 
like 3-5 minutes to look at a PR.
Long texts put me in a tricky spot because I either simply don't read anything 
from it or postpone the patch for possibly days until I can spare the time. I 
don't think any of these are really great.

https://github.com/llvm/llvm-project/pull/182377
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to