alexfh accepted this revision. alexfh added a comment. Still LG with one comment.
================ Comment at: clang-tidy/modernize/MakeSmartPtrCheck.h:60 - void replaceNew(DiagnosticBuilder &Diag, const CXXNewExpr *New, + /// Returns whether the fixes for replacing CXXNewExpr are generated. + bool replaceNew(DiagnosticBuilder &Diag, const CXXNewExpr *New, ---------------- I'd suggest using a less ambiguous phrase: instead of "Returns whether X." I write "Returns \c true when X". https://reviews.llvm.org/D36786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
