hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: test/clang-tidy/modernize-make-unique.cpp:253
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
- // CHECK-FIXES: std::unique_ptr<E> PE2 = std::make_unique<E>({1, 2});
----------------
alexfh wrote:
> I'd leave CHECK-FIXES with the original text to ensure no unwanted
> replacements are performed.
Indeed, this is a good suggestion, and it discovered an issue of this patch
(there are unexpected replacements generated for these cases).
I have updated the patch which changes a bit more code, please take a look
again.
https://reviews.llvm.org/D36786
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
