rjmccall added a comment. Hmm. Could you invert those conditions so that they early-return, just for consistency? Sorry this is dragging out so long, and thanks for being so patient.
================ Comment at: lib/CodeGen/TargetInfo.cpp:2357 + return; + X86_32TargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition); ---------------- rjmccall wrote: > That function has its own early exit, so do the early exit after calling it, > please. Here. ================ Comment at: lib/CodeGen/TargetInfo.cpp:2401 + if (!IsForDefinition) + return; + TargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition); ---------------- And this one should go after the call; I just missed it in the earlier reviews. ================ Comment at: lib/CodeGen/TargetInfo.cpp:5535 + ARMTargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition); + if (IsForDefinition) + addStackProbeSizeTargetAttribute(D, GV, CGM); ---------------- Here. Repository: rL LLVM https://reviews.llvm.org/D35479 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
