rjmccall added a comment. A few more minor tweaks.
================ Comment at: lib/CodeGen/TargetInfo.cpp:2357 + return; + X86_32TargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition); ---------------- That function has its own early exit, so do the early exit after calling it, please. ================ Comment at: lib/CodeGen/TargetInfo.cpp:5538 + return; + ARMTargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition); addStackProbeSizeTargetAttribute(D, GV, CGM); ---------------- Same thing here. ================ Comment at: lib/CodeGen/TargetInfo.cpp:6643 + + // Other attributes do not have a sense for declarations. + if (!IsForDefinition) ---------------- "meaning" is a better word here. Repository: rL LLVM https://reviews.llvm.org/D35479 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
