klimek added inline comments.
================ Comment at: include/clang/Tooling/CrossTranslationUnit.h:53-58 + /// \p CrossTUDir directory, called \p IndexName. In case the declaration is + /// found in the index the corresponding AST file will be loaded and the + /// definition of the function will be merged into the original AST using + /// the AST Importer. The declaration with the definition will be returned. + /// + /// Note that the AST files should also be in the \p CrossTUDir. ---------------- xazax.hun wrote: > klimek wrote: > > In the future we'll want to create an index interface around this (which > > will probably serve also what the refactoring integration would be based > > on), instead of piping files and directories into all classes. > > > > Perhaps we can start this by already pulling out a class ProjectIndex or > > somesuch, with methods like loadASTDefining(...)? > > > While I do agree to have an interface for that would be really good, but > maybe it would be better to first review and accept this patch and after that > design the interface in a follow-up patch (so https://reviews.llvm.org/D30691 > is not blocked). What do you think? I'm generally fine with that, and mainly looped in other folks to see whether anybody else has concerns. https://reviews.llvm.org/D34512 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
