klimek added a comment. General direction looks good.
I think in addition to integration tests through the static analyzer, we should still have unit tests. ================ Comment at: include/clang/Tooling/CrossTranslationUnit.h:47 + + const FunctionDecl *getCTUDefinition(const FunctionDecl *FD, StringRef CTUDir, + StringRef IndexName); ---------------- I'd just spell out Cross & s/CTUDIR/IndexDir/ perhaps? (if CTUDir is to contain the indices) I think as this is the major API entry point, a comment that explains the meaning of the arguments and how to use them would be nice. https://reviews.llvm.org/D34512 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
