Typz marked 3 inline comments as done.
Typz added inline comments.

================
Comment at: include/clang/Format/Format.h:234
 
+  bool allowEmptyFunctionsOnASingleLine() const {
+      return AllowShortFunctionsOnASingleLine >= ShortFunctionStyle::SFS_Empty;
----------------
djasper wrote:
> I'd prefer these functions not to be in the public header file. They are 
> implementation details. Either find a header/cpp-file in the lib/ directory 
> to place them in or just remove them for now. They are both still quite small 
> and called only twice each.
This is similar to the isCpp() method, to provide a better abstraction in the 
implementation.
I cannot find any better place, so I will remove them.


https://reviews.llvm.org/D34399



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to