djasper added inline comments.
================
Comment at: include/clang/Format/Format.h:234
+ bool allowEmptyFunctionsOnASingleLine() const {
+ return AllowShortFunctionsOnASingleLine >= ShortFunctionStyle::SFS_Empty;
----------------
I'd prefer these functions not to be in the public header file. They are
implementation details. Either find a header/cpp-file in the lib/ directory to
place them in or just remove them for now. They are both still quite small and
called only twice each.
================
Comment at: unittests/Format/FormatTest.cpp:6530
+ verifyFormat("int f() {\n"
+ "}", MergeInlineOnly);
+
----------------
Missing line break.
================
Comment at: unittests/Format/FormatTest.cpp:6548
+ "{\n"
+ "}", MergeInlineOnly);
+ verifyFormat("class C {\n"
----------------
Missing line break. Generally use clang-format on the patches :).
https://reviews.llvm.org/D34399
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
