llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-analysis Author: Yitzhak Mandelbaum (ymand) <details> <summary>Changes</summary> Commit #<!-- -->3ecfc03 introduced a bug involving an uninitialized field in `exportLogicalContext`. This patch initializes the field properly. --- Full diff: https://github.com/llvm/llvm-project/pull/154575.diff 1 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp (+3-3) ``````````diff diff --git a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp index 06a88784a6f94..4196d6821c184 100644 --- a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp @@ -285,10 +285,10 @@ SimpleLogicalContext DataflowAnalysisContext::exportLogicalContext( llvm::DenseSet<dataflow::Atom> TargetTokens) const { SimpleLogicalContext LC; - if (Invariant != nullptr) { - LC.Invariant = Invariant; + // Copy `Invariant` even if it is null, to initialize the field. + LC.Invariant = Invariant; + if (Invariant != nullptr) getReferencedAtoms(*Invariant, TargetTokens); - } llvm::DenseSet<dataflow::Atom> Dependencies = collectDependencies(std::move(TargetTokens)); `````````` </details> https://github.com/llvm/llvm-project/pull/154575 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
