https://github.com/ymand created
https://github.com/llvm/llvm-project/pull/154575
Commit #3ecfc03 introduced a bug involving an uninitialized field in
`exportLogicalContext`. This patch initializes the field properly.
>From 3b7e7843cf6c5422a4bd8ea85780663596b3dd46 Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum <yitzh...@google.com>
Date: Wed, 20 Aug 2025 16:51:09 +0000
Subject: [PATCH] [clang][dataflow] Fix uninitialized memory bug.
Commit #3ecfc03 introduced a bug involving an uninitialized field in
`exportLogicalContext`. This patch initializes the field properly.
---
.../lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
index 06a88784a6f94..4196d6821c184 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
@@ -285,10 +285,10 @@ SimpleLogicalContext
DataflowAnalysisContext::exportLogicalContext(
llvm::DenseSet<dataflow::Atom> TargetTokens) const {
SimpleLogicalContext LC;
- if (Invariant != nullptr) {
- LC.Invariant = Invariant;
+ // Copy `Invariant` even if it is null, to initialize the field.
+ LC.Invariant = Invariant;
+ if (Invariant != nullptr)
getReferencedAtoms(*Invariant, TargetTokens);
- }
llvm::DenseSet<dataflow::Atom> Dependencies =
collectDependencies(std::move(TargetTokens));
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
