llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Thibault Monnier (Thibault-Monnier) <details> <summary>Changes</summary> This PR inlines the InputsOk function in clang Compilation.cpp driver, because it was just a simple function call and was called only once. In addition, inlining it allows removing the double negation. --- Full diff: https://github.com/llvm/llvm-project/pull/152875.diff 1 Files Affected: - (modified) clang/lib/Driver/Compilation.cpp (+1-6) ``````````diff diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp index a39952e3c280a..4e300316ae9ba 100644 --- a/clang/lib/Driver/Compilation.cpp +++ b/clang/lib/Driver/Compilation.cpp @@ -232,11 +232,6 @@ static bool ActionFailed(const Action *A, return false; } -static bool InputsOk(const Command &C, - const FailingCommandList &FailingCommands) { - return !ActionFailed(&C.getSource(), FailingCommands); -} - void Compilation::ExecuteJobs(const JobList &Jobs, FailingCommandList &FailingCommands, bool LogOnly) const { @@ -245,7 +240,7 @@ void Compilation::ExecuteJobs(const JobList &Jobs, // In all but CLMode, execute all the jobs unless the necessary inputs for the // job is missing due to previous failures. for (const auto &Job : Jobs) { - if (!InputsOk(Job, FailingCommands)) + if (ActionFailed(&Job.getSource(), FailingCommands)) continue; const Command *FailingCommand = nullptr; if (int Res = ExecuteCommand(Job, FailingCommand, LogOnly)) { `````````` </details> https://github.com/llvm/llvm-project/pull/152875 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
