https://github.com/Thibault-Monnier created
https://github.com/llvm/llvm-project/pull/152875
This PR inlines the InputsOk function in clang Compilation.cpp driver, because
it was just a simple function call and was called only once. In addition,
inlining it allows removing the double negation.
>From 2df0db4032883750a75d5615bed4c011561c1c2c Mon Sep 17 00:00:00 2001
From: Thibault-Monnier <thibaultmo...@gmail.com>
Date: Sat, 9 Aug 2025 20:27:06 +0200
Subject: [PATCH] Inline `InputsOk` function in
`clang/lib/Driver/Compilation.cpp`
---
clang/lib/Driver/Compilation.cpp | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp
index a39952e3c280a..4e300316ae9ba 100644
--- a/clang/lib/Driver/Compilation.cpp
+++ b/clang/lib/Driver/Compilation.cpp
@@ -232,11 +232,6 @@ static bool ActionFailed(const Action *A,
return false;
}
-static bool InputsOk(const Command &C,
- const FailingCommandList &FailingCommands) {
- return !ActionFailed(&C.getSource(), FailingCommands);
-}
-
void Compilation::ExecuteJobs(const JobList &Jobs,
FailingCommandList &FailingCommands,
bool LogOnly) const {
@@ -245,7 +240,7 @@ void Compilation::ExecuteJobs(const JobList &Jobs,
// In all but CLMode, execute all the jobs unless the necessary inputs for
the
// job is missing due to previous failures.
for (const auto &Job : Jobs) {
- if (!InputsOk(Job, FailingCommands))
+ if (ActionFailed(&Job.getSource(), FailingCommands))
continue;
const Command *FailingCommand = nullptr;
if (int Res = ExecuteCommand(Job, FailingCommand, LogOnly)) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
