mylai-mtk wrote: @efriedma-quic Thanks for pointing out the potential type incompatibilities regarding the current mangling scheme.
Regarding this issue, I believe there's currently no perfect solution given the complexity of C type compatibility. It looks like even in the AArch64 PtrAuth implementation you referred to (https://github.com/llvm/llvm-project/pull/96992), some known compatible cases still result in incompatible mangling results. Given that the mangling scheme implemented here had already undergone extensive discussion in https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/434 , I would prefer to avoid spec-induced type compatibility issues and focus on implementation in this PR. If you have any concrete case which you believe should result in compatible mangling results but does not due to the draft spec, please raise the issue in the RISC-V psABI thread https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/434 , so people there (me included, of course) would be able to incorporate the solution into the spec. This PR is just an implementation of the psABI spec. For this PR, please comment on mangling issues only if it arises from mis-implementation of the draft spec. Thank you. https://github.com/llvm/llvm-project/pull/111661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
