https://github.com/tblah requested changes to this pull request.
The code changes look okay here but I think the naming should reflect that the lowering to upstream MLIR dialects will be considered experimental (and may remain so forever, if it cannot be made to fully conform to Fortran semantics or show runtime performance improvements that justify the added complexity and compile time). Instead of re-purposing `-emit-mlir`, how about `-emit-experimental-mlir`? Thank you for upstreaming your work aligning flang with upstream mlir dialects. I am personally very interested in this. But I think making such a significant change to the lowering pipeline is going to need a lot broader consensus amongst flang contributors and strong technical justification. For now I am very happy to see any work in this direction under experimental options :smile: https://github.com/llvm/llvm-project/pull/139857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
