Endilll wrote: > @Endilll I added the tests as discussed on #138074 .
Thank you! > I'm just not sure how/if we can reasonably test the `else` path for > `briefComment`: this requires a `libclang.so` built before LLVM 3.2 (the > check was added 13 years ago in > [b947e82](https://github.com/llvm/llvm-project/commit/b947e8239f311ff88c3f874d120ae4e41c9659d0)). > In fact, I'm not entirely sure what the point here is: being able to use the > same `libclang.so` with a newer `cindex.py` and then returning nonsense > instead of erroring out surely can't be the goal, right? Perhaps we're better > off removing the if/else part entirely? I believe Python bindings are designed to work with the matching libclang version, and we don't have to support quirks of older libclang versions. Users of older versions should use matching bindings version instead. https://github.com/llvm/llvm-project/pull/138132 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
