https://github.com/mizvekov commented:
I won't have time to review this closely until next week. I think the 'inside profile' is a red herring here, this looks more like a problem from calling it from within deserialization. We could try getting to the bottom of it and see if we can assert in the problematic cases, to avoid future repeats of the problem. But the fix here is fine on its own, we don't need the most recent decl in most cases, and we kept one getter only for simplicity. Though I think the name of the new getter needs more thought, it needs to avoid confusion with similar methods from the base type class. Though I won't have time to give input on that until the weekend at least. https://github.com/llvm/llvm-project/pull/137910 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
