[clang] [Driver] Use *Set::insert_range (NFC) (PR #133201)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-driver

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>

This patch uses a range constructor to collapse:

  llvm::StringSet&lt;&gt; Dest;
  for (const auto &amp;S : Src)
    Dest.insert(S);

down to:

  llvm::StringSet&lt;&gt; Dest(llvm::from_range, Src);


---
Full diff: https://github.com/llvm/llvm-project/pull/133201.diff


2 Files Affected:

- (modified) clang/lib/Driver/Job.cpp (+1-3) 
- (modified) clang/lib/Driver/Multilib.cpp (+2-6) 


``````````diff
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp
index ae2f1cd1f56c9..4619b8c1887be 100644
--- a/clang/lib/Driver/Job.cpp
+++ b/clang/lib/Driver/Job.cpp
@@ -140,9 +140,7 @@ void Command::buildArgvForResponseFile(
     return;
   }
 
-  llvm::StringSet<> Inputs;
-  for (const auto *InputName : InputFileList)
-    Inputs.insert(InputName);
+  llvm::StringSet<> Inputs(llvm::from_range, InputFileList);
   Out.push_back(Executable);
 
   if (PrependArg)
diff --git a/clang/lib/Driver/Multilib.cpp b/clang/lib/Driver/Multilib.cpp
index a92ad4718fb6e..87fa1af54a8ea 100644
--- a/clang/lib/Driver/Multilib.cpp
+++ b/clang/lib/Driver/Multilib.cpp
@@ -60,9 +60,7 @@ void Multilib::print(raw_ostream &OS) const {
 bool Multilib::operator==(const Multilib &Other) const {
   // Check whether the flags sets match
   // allowing for the match to be order invariant
-  llvm::StringSet<> MyFlags;
-  for (const auto &Flag : Flags)
-    MyFlags.insert(Flag);
+  llvm::StringSet<> MyFlags(llvm::from_range, Flags);
 
   for (const auto &Flag : Other.Flags)
     if (!MyFlags.contains(Flag))
@@ -272,9 +270,7 @@ bool MultilibSet::select(
 
 llvm::StringSet<>
 MultilibSet::expandFlags(const Multilib::flags_list &InFlags) const {
-  llvm::StringSet<> Result;
-  for (const auto &F : InFlags)
-    Result.insert(F);
+  llvm::StringSet<> Result(llvm::from_range, InFlags);
   for (const FlagMatcher &M : FlagMatchers) {
     std::string RegexString(M.Match);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/133201
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits