https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/133201
This patch uses a range constructor to collapse:
llvm::StringSet<> Dest;
for (const auto &S : Src)
Dest.insert(S);
down to:
llvm::StringSet<> Dest(llvm::from_range, Src);
>From 5f536050eb4df44099e500b868ee747f11da97f0 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Wed, 26 Mar 2025 18:17:37 -0700
Subject: [PATCH] [Driver] Use *Set::insert_range (NFC)
This patch uses a range constructor to collapse:
llvm::StringSet<> Dest;
for (const auto &S : Src)
Dest.insert(S);
down to:
llvm::StringSet<> Dest(llvm::from_range, Src);
---
clang/lib/Driver/Job.cpp | 4 +---
clang/lib/Driver/Multilib.cpp | 8 ++------
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp
index ae2f1cd1f56c9..4619b8c1887be 100644
--- a/clang/lib/Driver/Job.cpp
+++ b/clang/lib/Driver/Job.cpp
@@ -140,9 +140,7 @@ void Command::buildArgvForResponseFile(
return;
}
- llvm::StringSet<> Inputs;
- for (const auto *InputName : InputFileList)
- Inputs.insert(InputName);
+ llvm::StringSet<> Inputs(llvm::from_range, InputFileList);
Out.push_back(Executable);
if (PrependArg)
diff --git a/clang/lib/Driver/Multilib.cpp b/clang/lib/Driver/Multilib.cpp
index a92ad4718fb6e..87fa1af54a8ea 100644
--- a/clang/lib/Driver/Multilib.cpp
+++ b/clang/lib/Driver/Multilib.cpp
@@ -60,9 +60,7 @@ void Multilib::print(raw_ostream &OS) const {
bool Multilib::operator==(const Multilib &Other) const {
// Check whether the flags sets match
// allowing for the match to be order invariant
- llvm::StringSet<> MyFlags;
- for (const auto &Flag : Flags)
- MyFlags.insert(Flag);
+ llvm::StringSet<> MyFlags(llvm::from_range, Flags);
for (const auto &Flag : Other.Flags)
if (!MyFlags.contains(Flag))
@@ -272,9 +270,7 @@ bool MultilibSet::select(
llvm::StringSet<>
MultilibSet::expandFlags(const Multilib::flags_list &InFlags) const {
- llvm::StringSet<> Result;
- for (const auto &F : InFlags)
- Result.insert(F);
+ llvm::StringSet<> Result(llvm::from_range, InFlags);
for (const FlagMatcher &M : FlagMatchers) {
std::string RegexString(M.Match);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
