ilovepi wrote:
hey, sorry, I ended up landing
https://github.com/llvm/llvm-project/pull/131939. There are two reasons: 1) I
really wanted to fix that crash ASAP. 2) I made the mistake of stacking other
patches on top of it with graphite, and it turns out it isn't easy to reorder
them. As a result I couldn't fix the basic functionality of HTML links without
reuploading the entire rest of the stack. Normally, I'd much prefer to just
mentor you through the process, but I really needed to fix those links.
If you're still interested in working on this though, I think the test could be
improved , and I wouldn't mid seeing that code cleaned up. In particular, I'm
wondering how great of an idea it is to use those optionals, when we end up w/
a `.value_or("")`. The amount of unique_ptr we're using is also not the
greatest. And I wouldn't be surprised if using ASan/TSan on something like LLVM
wouldn't find several bugs. Lastly, the testing story in clang-doc is quite
weak. We've improved it a lot over last year's GSOC, but I still don't think
its all that well exercised.
https://github.com/llvm/llvm-project/pull/131698
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
