================
@@ -494,7 +494,7 @@ genReferencesBlock(const std::vector<Reference> &References,
static std::unique_ptr<TagNode>
writeFileDefinition(const Location &L,
std::optional<StringRef> RepositoryUrl = std::nullopt) {
- if (!L.IsFileInRootDir && !RepositoryUrl)
+ if (!L.IsFileInRootDir || !RepositoryUrl)
----------------
ilovepi wrote:
This logic isn't correct, and happens to prevent us from effectively using the
`--repository=` string anywhere, as evidenced by our tests.
I have some additional test changes that I'm in the process of adding that will
hopefully cover this case.
An alternative would be to change the deref of the option to use
`.value_or("")` instead.
https://github.com/llvm/llvm-project/pull/131698
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
