https://github.com/aaronpuchert approved this pull request.

Looks good to me, and thanks for the contribution!

> Note, I think for now it might be safer to not enable by default yet, but 
> I've made a note (and hinted at in changelog) that we're planning to default 
> enable in future, so that should give folks enough time to deal with new 
> findings without breaking things just yet.

If it's off by default it won't be used by a lot of people, and just the 
separate flag should be enough to unbreak the build, should it be necessary. 
But I'm also fine if you'd rather leave it opt-in for a bit and collect 
experiences before we include it in `-Wthread-safety`.

https://github.com/llvm/llvm-project/pull/127396
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to