melver wrote: > I think this looks very good! I just have some minor remarks. > > Thanks to @aoates for trying this out, this is always appreciated! > > And sorry for the delay.
Thanks for the review! I addressed the comments, PTAL. Note, I think for now it might be safer to not enable by default yet, but I've made a note (and hinted at in changelog) that we're planning to default enable in future, so that should give folks enough time to deal with new findings without breaking things just yet. Looking forward to landing this, as I'm sure it'll also uncover new findings in existing codebases using -Wthread-safety already. https://github.com/llvm/llvm-project/pull/127396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
