https://github.com/ilya-biryukov commented:

I only have a few comments about documenting the caveats (no alias analysis).

The actual code changes look very simple and this looks like a clear 
improvement that would catch many useful cases.

I don't have much experience with this code and would still advise to wait 
until someone more familiar with the code takes a look. But happy to give a 
general LGTM after the documentation is improved.

https://github.com/llvm/llvm-project/pull/127396
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to