=?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/116...@github.com>
================ @@ -7400,7 +7407,25 @@ bool DecomposePrintfHandler::GetSpecifiers( [](const EquatableFormatArgument &A, const EquatableFormatArgument &B) { return A.getPosition() < B.getPosition(); }); - return true; + + // If there are duplicate positional arguments, ensure that they are all + // mutually compatible. + bool HadError = false; + auto ArgIter = Args.begin(); + auto ArgEnd = Args.end(); + while (ArgIter != ArgEnd) { ---------------- erichkeane wrote: I don't have time to understand this yet... but this looks like it should be composible with some std/ADT algorithms, and should be. https://github.com/llvm/llvm-project/pull/116708 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits