=?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com>, =?utf-8?q?Félix?= Cloutier <fclout...@apple.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/116...@github.com>
apple-fcloutier wrote: Happy February everyone! @shafik, I added tests for the situations you called out, which did reveal a number of weaknesses and caused changes as a result. @erichkeane, in January I had plans to make a second PR, but since some of my changes would address Shafik's comments, I folded them in entirely. I can address any new feedback you have, of course. As last time, I recommend checking the diff with [?w=1](https://github.com/llvm/llvm-project/pull/116708/files?w=1). As I said before, I lost the ability to merge PRs. We may need you (or @ahatanak) to click the button when we are ready. https://github.com/llvm/llvm-project/pull/116708 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits