steakhal wrote:

I've pushed a couple of commits to sync this PR with what I had in mind.
I hope you don't mind @Flandini.

Please anyone do a thorough review.

---

I've considered uplifiting a couple of the `VarRegion::getStackFrame()`, and 
similar `getStackFrame()` functions, because internally they would use the 
memory space to resolve to the stack frame. I still consider it, but it would 
need a similar migration: introduce a new overload that takes the State, and 
try to eradicate the overload that doesn't take any State. Then keep the cases 
that cannot be uplifted. I found this tedious, and not strictly necessary as a 
first step to merge this PR. It would also "pollute" the API surface with the 
leftover APIs, which isn't ideal.

https://github.com/llvm/llvm-project/pull/123003
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to