Author: Kazu Hirata Date: 2025-02-02T09:31:06-08:00 New Revision: 43b7124c5749b3f3276adf1b869e623e163e230e
URL: https://github.com/llvm/llvm-project/commit/43b7124c5749b3f3276adf1b869e623e163e230e DIFF: https://github.com/llvm/llvm-project/commit/43b7124c5749b3f3276adf1b869e623e163e230e.diff LOG: [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#125379) Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with // isa<T>, cast<T> and the llvm::dyn_cast<T> This patch migrates the use of PointerUnion::dyn_cast to dyn_cast_if_present because the non-const variant of getInitializedFieldInUnion is known to encounter null in ArrayFillerOrUnionFieldInit. See: commit 563c7c5539f05e7f8cbb42565c1f24466019f38b Author: Kazu Hirata <k...@google.com> Date: Sat Jan 25 14:05:01 2025 -0800 FWIW, I am not aware of any test case in check-clang that triggers null here. Added: Modified: clang/include/clang/AST/ExprCXX.h Removed: ################################################################################ diff --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h index 0b6c8cfb163c958..98ba2bb41bb54d9 100644 --- a/clang/include/clang/AST/ExprCXX.h +++ b/clang/include/clang/AST/ExprCXX.h @@ -5040,7 +5040,7 @@ class CXXParenListInitExpr final } const FieldDecl *getInitializedFieldInUnion() const { - return ArrayFillerOrUnionFieldInit.dyn_cast<FieldDecl *>(); + return dyn_cast_if_present<FieldDecl *>(ArrayFillerOrUnionFieldInit); } child_range children() { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
