thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land.
Looks like a cool warning. Two suggestions for more exhaustive testing, but I think this looks good. ================ Comment at: test/SemaCXX/warn-bitfield-enum-conversion.cpp:1 +// RUN: %clang_cc1 -std=c++11 -triple x86_64-windows-msvc -verify %s -Wbitfield-enum-conversion + ---------------- Consider also running this test with a triple where enums don't default to signed. ================ Comment at: test/SemaCXX/warn-bitfield-enum-conversion.cpp:15 + + ThreeBits three_bits_enum : 3; +}; ---------------- Also add a : 4 version and check that that doesn't warn? https://reviews.llvm.org/D30923 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
