chandlerc wrote: For many of the comments -- this, like the previous PR, is script generated based on the physical grouping of the current `.def` file. My preference would be to land it without trying to massage to better utilize the TableGen features, as I'd really like to get the first cut in as an exact translation with a script. Also, while I agree with all the comments you make, maybe you or one of the other maintainers can pick up some of these incremental improvements in subsequent PRs? This one still seems to be a positive step and to make it easier to start to consider these.
> I don't see any removal in BuiltinsX86_64.def. Is it intended? Doh, I just forgot to do the git operation. Sorry about that. I'll get an updated version of this and the other PR after re-basing and such tomorrow. https://github.com/llvm/llvm-project/pull/121043 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
