================
@@ -910,7 +910,10 @@ void darwin::Lipo::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(II.getFilename());
}
- const char *Exec = Args.MakeArgString(getToolChain().GetProgramPath("lipo"));
+ std::string LipoName =
+ std::string(Args.getLastArgValue(options::OPT_fuse_lipo_EQ, "lipo"));
+ const char *Exec =
+ Args.MakeArgString(getToolChain().GetProgramPath(LipoName.c_str()));
----------------
carlocab wrote:
Seems a bit much to create a throwaway `std::string` here. Something like this
should work:
```suggestion
StringRef LipoName =
Args.getLastArgValue(options::OPT_fuse_lipo_EQ, "lipo");
const char *Exec =
Args.MakeArgString(getToolChain().GetProgramPath(LipoName.data()));
```
https://github.com/llvm/llvm-project/pull/121231
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
