hans added a comment. In https://reviews.llvm.org/D29221#686865, @amaiorano wrote:
> Made changes based on @hans 's feedback. > > I looked again at the categories, and I think it makes sense with my changes. > Here's an updated screenshot that shows what the options menu in Visual > Studio looks like with these changes with the top-level category name > ("LLVM/Clang") and page name ("Clang Format") highlighted, as well as the > category names for the page items ("Format Options" and "Format On Save") > highlighted: > > F3117958: pasted_file <https://reviews.llvm.org/F3117958> > > It would be nice if "Format On Save" was _below_ "Format Options", but Visual > Studio always orders the page categories in alphabetical order, so this is > pretty standard. The screenshot looks good. My only nit is that I'd prefer "clang-format" instead of "ClangFormat". Manuel: the menu options under Tools currently say "Clang Format {Selection,Document}". What do you think about using "clang-format" here instead? That is the name of the tool after all, and I think it also works nicely as a verb. I realize the actual extension is called ClangFormat, but maybe there were reasons for that, or we have to live with it? https://reviews.llvm.org/D29221 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits