amaiorano added a comment.
In https://reviews.llvm.org/D29221#688697, @hans wrote:
> >>> My only nit is that I'd prefer "clang-format" instead of "ClangFormat".
> >>>
> >>> Manuel: the menu options under Tools currently say "Clang Format
> >>> {Selection,Document}". What do you think about using "clang-format" here
> >>> instead? That is the name of the tool after all, and I think it also
> >>> works nicely as a verb.
> >>>
> >>> I realize the actual extension is called ClangFormat, but maybe there
> >>> were reasons for that, or we have to live with it?
> >>
> >> I would also like clang-format in there rather than ClangFormat. One thing
> >> to validate is whether this change would mean people would lose their
> >> changes to the defaults in the configuration panel. I'll run some tests
> >> and see if this is indeed the case. Maybe there's a way to keep the
> >> internal name the same for config purposes, but change the displayed name
> >> instead. Will get back to you.
> >
> > Okay, I looked into it, and the good news is that changing the name of the
> > category from ClangFormat to clang-format doesn't reset the previously
> > saved changes made in the options menu. I also changed the menu item names.
> > Here's what both would look like:
> >
> > F3119242: pasted_file <https://reviews.llvm.org/F3119242>
> >
> > F3119244: pasted_file <https://reviews.llvm.org/F3119244>
> >
> > Now having said that, I'm not sure if this is the best change because of a
> > few things:
> >
> > 1. The extension's name itself is ClangFormat, which was recently added to
> > the Visual Studio market place here:
> > https://marketplace.visualstudio.com/items?itemName=HansWennborg.ClangFormat
> > . Consequently, the extension appears with this name in the Visual Studio
> > extensions dialog: F3119249: pasted_file
> > <https://reviews.llvm.org/F3119249>. I don't think it would be easy to
> > change this. You cannot really take down an extension page on the
> > marketplace once it's there; you'd have to document that it has been
> > deprecated and provide a link to a new page. When searching for it in the
> > Extensions dialog in VS, though, both the old and new extension would show
> > up.
> > 2. Although the name of the executable is indeed "clang-format", the
> > documentation here <http://clang.llvm.org/docs/ClangFormat.html> uses the
> > name ClangFormat: F3119251: pasted_file <https://reviews.llvm.org/F3119251>
> >
> > So I leave it up to you whether you really want this change or not. We
> > can also decide later rather than fold it into this change.
>
> Personally I think we should refer to the tool and the action of formatting
> as "clang-format" as much as possible. It's unfortunate we can't rename the
> extension, but maybe that slight inconsistency isn't the end of the world.
>
> Manuel, Daniel: I'd like to hear your opinions here.
Hey guys, any feedback on this? About 1.5 weeks ago, @hans asked @klimek and
@djasper for their opinions on "clang-format" vs "ClangFormat". Thanks!
https://reviews.llvm.org/D29221
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
