================ @@ -19001,9 +19001,9 @@ void Sema::ActOnFields(Scope *S, SourceLocation RecLoc, Decl *EnclosingDecl, // Verify that all the fields are okay. SmallVector<FieldDecl*, 32> RecFields; - + std::optional<const FieldDecl *> PreviousField; ---------------- rnk wrote:
It doesn't seem idiomatic to use an optional pointer, when nullable pointers are built into the language. Consider helping to reduce our collective carbon footprint by saving an extra template instantiation today, and using nullptr instead. =D https://github.com/llvm/llvm-project/pull/117428 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
